archiver: tests: simplify a bit further

We don't need to risk failure and use time.ParseDuration to get 2 *
time.Second.

else if isn't really necessary if the conditions are simple enough and lead
to the same result.

services/archiver/archiver_test.go

@@ -137,8 +137,7 @@ func TestArchive_Basic(t *testing.T) {
 	ArchiveRepository(zipReq)
 
 	// Sleep two seconds to make sure the queue doesn't change.
-	twoSeconds, _ := time.ParseDuration("2s")
+	time.Sleep(2 * time.Second)
-	time.Sleep(twoSeconds)
 	assert.Equal(t, 3, len(archiveInProgress))
 
 	// Release them all, they'll then stall at the archiveQueueReleaseCond while
@@ -150,9 +149,7 @@ func TestArchive_Basic(t *testing.T) {
 	// 8 second timeout for them all to complete.
 	timeout := time.Now().Add(8 * time.Second)
 	for {
-		if allComplete(inFlight) {
+		if allComplete(inFlight) || time.Now().After(timeout) {
-			break
-		} else if time.Now().After(timeout) {
 			break
 		}
 	}