Platform_Mirocod

11791 Commits

14 Branches

154 Tags

505 MiB

Tree: d268c9d6e1

Commit Graph

Author	SHA1	Message	Date
zeripath	3d8b5ad5f3	Fix a couple of CommentAsPatch issues. (#14804 ) * CutDiffAroundLine makes the incorrect assumption that `---` and `+++` always represent part of the header of a diff. This PR adds a flag to its parsing to prevent this problem and adds a streaming parsing technique to CutDiffAroundLine using an io.pipe instead of just sending data to an unbounded buffer. Fix #14711 Signed-off-by: Andrew Thornton <art27@cantab.net> * Handle unquoted comment patch files When making comment patches unfortunately the patch does not always quote the filename This makes the diff --git header ambiguous again. This PR finally adds handling for ambiguity in to parse patch Fix #14812 Signed-off-by: Andrew Thornton <art27@cantab.net> * Add in testing for no error There is no way currently for CutDiffAroundLine in this test to cause an error however, it should still be tested. Signed-off-by: Andrew Thornton <art27@cantab.net>	4 years ago
Lunny Xiao	e8860ef4f9	Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments (#9996 ) * Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments * fix test * fix lint * Change error log to warn	5 years ago

Author

SHA1

Message

Date

zeripath

3d8b5ad5f3

Fix a couple of CommentAsPatch issues. (#14804 )

* CutDiffAroundLine makes the incorrect assumption that `---` and `+++` always represent part of the header of a diff.

This PR adds a flag to its parsing to prevent this problem and adds a streaming parsing technique to CutDiffAroundLine using an io.pipe instead of just sending data to an unbounded buffer.

Fix #14711

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Handle unquoted comment patch files

When making comment patches unfortunately the patch does not always quote the filename
This makes the diff --git header ambiguous again.

This PR finally adds handling for ambiguity in to parse patch

Fix #14812

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add in testing for no error

There is no way currently for CutDiffAroundLine in this test to cause an
error however, it should still be tested.

Signed-off-by: Andrew Thornton <art27@cantab.net>

4 years ago

Lunny Xiao

e8860ef4f9

Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments (#9996 )

* Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments

* fix test

* fix lint

* Change error log to warn

5 years ago

2 Commits (d268c9d6e14f749c4631892b7faabd0a7d77d29a)