Platform_Mirocod

7437 Commits

14 Branches

154 Tags

505 MiB

Tree: c64fe091d3

Commit Graph

Author	SHA1	Message	Date
mrsdizzie	ca46385637	Clean up various use of escape/unescape functions for URL generation (#6334 ) * Use PathUnescape instead of QueryUnescape when working with branch names Currently branch names with a '+' fail in certain situations because QueryUnescape replaces the + character with a blank space. Using PathUnescape should be better since it is defined as: // PathUnescape is identical to QueryUnescape except that it does not // unescape '+' to ' ' (space). Fixes #6333 * Change error to match new function name * Add new util function PathEscapeSegments This function simply runs PathEscape on each segment of a path without touching the forward slash itself. We want to use this instead of PathEscape/QueryEscape in most cases because a forward slash is a valid name for a branch etc... and we don't want that escaped in a URL. Putting this in new file url.go and also moving a couple similar functions into that file as well. * Use EscapePathSegments where appropriate Replace various uses of EscapePath/EscapeQuery with new EscapePathSegments. Also remove uncessary uses of various escape/unescape functions when the text had already been escaped or was not escaped. * Reformat comment to make drone build happy * Remove no longer used url library * Requested code changes	6 years ago
Julien Tant	dea3d849e1	Give user a link to create PR after push (#4716 ) * Give user a link to create PR after push * Forks now create PR in the base repository + make sure PR creation is allowed * fix code style	6 years ago

Author

SHA1

Message

Date

mrsdizzie

ca46385637

Clean up various use of escape/unescape functions for URL generation (#6334 )

* Use PathUnescape instead of QueryUnescape when working with branch names

Currently branch names with a '+' fail in certain situations because
QueryUnescape replaces the + character with a blank space.

Using PathUnescape should be better since it is defined as:

// PathUnescape is identical to QueryUnescape except that it does not
// unescape '+' to ' ' (space).

Fixes #6333

* Change error to match new function name

* Add new util function PathEscapeSegments

This function simply runs PathEscape on each segment of a path without
touching the forward slash itself. We want to use this instead of
PathEscape/QueryEscape in most cases because a forward slash is a valid name for a
branch etc... and we don't want that escaped in a URL.

Putting this in new file url.go and also moving a couple similar
functions into that file as well.

* Use EscapePathSegments where appropriate

Replace various uses of EscapePath/EscapeQuery with new
EscapePathSegments. Also remove uncessary uses of various
escape/unescape functions when the text had already been escaped or was
not escaped.

* Reformat comment to make drone build happy

* Remove no longer used url library

* Requested code changes

6 years ago

Julien Tant

dea3d849e1

Give user a link to create PR after push (#4716 )

* Give user a link to create PR after push

* Forks now create PR in the base repository + make sure PR creation is allowed

* fix code style

6 years ago

2 Commits (c64fe091d3f23187a9d6ce73d8659f002f6eb936)