Platform_Mirocod

9337 Commits

14 Branches

154 Tags

505 MiB

Tree: 38d5f88a81

Commit Graph

Author	SHA1	Message	Date
赵智超	ef89e75d0e	add request review from specific reviewers feature in pull request (#10756 ) * add request review feature in pull request add a way to notify specific reviewers to review like github , by add or delet a special type review . The acton is is similar to Assign , so many code reuse the function and items of Assignee, but the meaning and result is different. The Permission style is is similar to github, that only writer can add a review request from Reviewers, but the poster can recall and remove a review request after a reviwer has revied even if he don't have Write Premission. only manager , the poster and reviewer of a request review can remove it. The reviewers can be requested to review contain all readers for private repo , for public, contain all writers and watchers. The offical Review Request will block merge if Reject can block it. an other change: add ui otify for Assignees. Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lauris BH <lauris@nix.lv> Signed-off-by: a1012112796 <1012112796@qq.com> * new change * add placeholder string * do some changes follow #10238 to add review requests num on lists also change icon for review requests to eye Co-authored-by: Lauris BH <lauris@nix.lv>	5 years ago
Lunny Xiao	495d5e4329	Move more issue assignee code from models to issue service (#8690 ) * Move more issue assignee code from models to issue service * fix test	5 years ago

Author

SHA1

Message

Date

赵智超

ef89e75d0e

add request review from specific reviewers feature in pull request (#10756 )

* add request review feature in pull request

add a way to notify specific reviewers to review like github , by add  or delet a  special type
review . The acton is  is similar to Assign ,  so many code reuse the function and items of
Assignee, but the meaning and result is different.

The Permission style is is similar to github, that only writer can add a review request from Reviewers,
but the poster can recall and remove a review request after a reviwer has revied even if he don't have
Write Premission. only manager , the poster and reviewer of a request review can remove it.

The reviewers can be requested to review contain all readers for private repo , for public, contain
all writers and watchers.

The offical Review Request will block merge if Reject can block it.

an other change: add ui otify for Assignees.

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: Lauris BH <lauris@nix.lv>

Signed-off-by: a1012112796 <1012112796@qq.com>

* new change

* add placeholder string

* do some changes follow #10238 to add review requests num on lists also
change icon for review requests to eye

Co-authored-by: Lauris BH <lauris@nix.lv>

5 years ago

Lunny Xiao

495d5e4329

Move more issue assignee code from models to issue service (#8690 )

* Move more issue assignee code from models to issue service

* fix test

5 years ago

2 Commits (38d5f88a8183147cc5ecc6ece58fc28836a4af8b)